Skip to content

Conversation

@chaserli
Copy link
Member

@chaserli chaserli commented Mar 10, 2024

Basically at this point it's useless to do all these checks.
What had the program done?

if(!this->IsArmed() || !this->Owner->ControlledByCurrentPlayer() || this->Owner==pObject->GetOwningHouse())
    if((this->Spawned || !this->ControlledByCurrentPlayer)
          && pObject->CanBeSelected() &&..)
         return Action::Select;
 
 return Action::None;

This is the very end of that function it's not sufficient to only let "me" select pObject if it belongs to this->Owner which is known to be controlled by me. It is also possible that "I" (the controller of this) can only control the owning house of pObject but is not it. In that case you gotta let me select it too

@github-actions
Copy link

github-actions bot commented Mar 10, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@chaserli chaserli requested a review from Belonit March 10, 2024 07:58
@chaserli chaserli marked this pull request as draft March 10, 2024 09:48
@chaserli chaserli marked this pull request as ready for review March 12, 2024 02:35
@Belonit
Copy link
Member

Belonit commented Mar 13, 2024

@chaserli If you don't mind, I'll get back to this PR in a couple of weeks. There are a few other things I'm busy with right now

@chaserli
Copy link
Member Author

@chaserli If you don't mind, I'll get back to this PR in a couple of weeks. There are a few other things I'm busy with right now

sure not, you could even work on #21 before this one

…when about to select

Co-Authored-By: Trsdy <9932846+chaserli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants