Skip to content

Conversation

@Fly-Star-him
Copy link
Contributor

Phobos allow the player to observe friendly units that have been cloaked, but they cannot be selected unless a unit with Sensors=yes is present nearby.
bug

So I made a short fix to select units with Sensors=yes even if they don't exist nearby.
fix

@Fly-Star-him Fly-Star-him changed the title [Simple Fix] Select Friendly Units that have been Cloaked [Simple Fix] Select Friendly Units that have been cloaked Sep 21, 2024
@Fly-Star-him Fly-Star-him changed the title [Simple Fix] Select Friendly Units that have been cloaked Select allied country units that have been cloaked Sep 21, 2024
@Fly-Star-him Fly-Star-him changed the title Select allied country units that have been cloaked [BugFix] Select allied country units that have been cloaked Sep 22, 2024
@github-actions
Copy link

github-actions bot commented Sep 23, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Copy link
Member

@MortonPL MortonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've run it and it looks like it also fixes a campaign bug with multiple player houses and uncontrollable stealth units.

From modified all01md.map:
image

Remember to add an entry in docs/Whats-New.md, CREDITS.md and docs/Fixed-or-Improved-Logics.md (bugfixes section). Once that's done, this PR can be merged.

@chaserli
Copy link
Contributor

Partially already implemented, partially in another PR

CnCNet/yrpp-spawner#20
https://github.com/CnCNet/yrpp-spawner/blob/main/src/Misc/Observers.Visibility.cpp

@Metadorius
Copy link
Member

So uhh what are we doing with this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants