[SwiftDriver] Part III - Introduce synchronization between swift-frontend invocations #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polac24
commented
Jun 4, 2023
| ```shell | ||
| ditto "${SCRIPT_INPUT_FILE_0}" "${SCRIPT_OUTPUT_FILE_0}" | ||
| [ -f "${SCRIPT_INPUT_FILE_1}" ] && ditto "${SCRIPT_INPUT_FILE_1}" "${SCRIPT_OUTPUT_FILE_1}" || rm "${SCRIPT_OUTPUT_FILE_1}" | ||
| [ -f "${SCRIPT_INPUT_FILE_1}" ] && ditto "${SCRIPT_INPUT_FILE_1}" "${SCRIPT_OUTPUT_FILE_1}" || rm -f "${SCRIPT_OUTPUT_FILE_1}" |
Collaborator
Author
There was a problem hiding this comment.
sidefix: found that if a first build has a cache miss, this snippet fails with an error that $SCRIPT_OUTPUT_FILE_1 doesn't exist. In such cases, we can safely no-op (so forcing rm)
polac24
requested review from
CognitiveDisson,
PatrikBillgren,
acbdev and
aleksandergrzyb
aleksandergrzyb
previously approved these changes
Jun 6, 2023
| ## Architectural designs | ||
| Follow the [Architectural designs](docs/design/ArchitecturalDesigns.md) document that describes and documents XCRemoteCache designs and implementation details. |
Contributor
There was a problem hiding this comment.
👍 Minor - the graphs are hard to read for dark mode.
Collaborator
Author
There was a problem hiding this comment.
thanks for spotting that! Fixed it.
| /// the critical section, the code realizes that remote cache cannot be used | ||
| /// (in practice - a new file has been added) | ||
| /// None of compilation process (so with '-c' args) can continue until the entire emit-module logic finishes | ||
| /// Because it is expected to happen no that often and emit-module is usually quite fast, this makes the |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Because it is expected to happen no that often and emit-module is usually quite fast, this makes the | |
| /// Because it is expected to happen not that often and emit-module is usually quite fast, this makes the |
aleksandergrzyb
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main PR of the Swift driver integration: synchronizes all swift-frontend invocations so emit-module (which is responsible to make the last check if the cached artifact can be used) is blocking
swift-frontent -c(compilation) invocations.Context
Because the design and implementation might not be obvious(relies on the swift driver integration in Xcode), they are documented in the markdown file (part of this PR), available to review here.
Previous PRs (#209 and #208)
Next steps
swift-frontentexecutables to the released .zip package^ All these missing parts will be added in Part IV (Draft)