Skip to content

Conversation

@polac24
Copy link
Collaborator

@polac24 polac24 commented Jun 6, 2023

The last part of the Swift integration support

  • bundles xcswift-frontent to the .zip (incl. the swift-frontend -> xcswift-frontend and swiftc -> xcswiftc symbolic links). Symlinks are added because Xcode's driver integration requires that the SWIFT_EXEC has swiftc filename, placed next to the swift-frontent
  • Add support of enable_swift_driver_integration: true in the CocoaPods plugin (the automatic integration already support that, added Refactor existing implementation for swift-driver change #208)
  • Duplicate all E2E tests in 2 modes: with and without enable_swift_driver_integration. That makes the E2E testing longer (~x2), but in the near future (when Xcode 14 support will be deprecated) we will be able to delete the legacy testing. Until we stabilize Swift Driver Integration, E2E tests will take more time. In a single CI, it seems the test pipeline takes 22min (vs 14m previously).
  • For the standalone E2E tests, build&generate artifacts for the M1/M2 machines (arm64). As M1 machines are already more popular than Intel machines, it is better to cover that architecture in tests.
  • Bumps the CocoaPods plugin, as there was a change in the implementation (0.0.17)

Previous PRs: #208, #209, #210

@polac24 polac24 merged commit b74e002 into spotify:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants