Skip to content

Make external/app sharing within Android more clear and platform-aligned #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 1 commit into from
Dec 18, 2025
Merged

Make external/app sharing within Android more clear and platform-aligned #2962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/it/niedermann/owncloud/notes/share/NoteShareActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,7 @@ public void applyBrand(int color) {
util.platform.themeHorizontalProgressBar(binding.progressBar);
util.platform.colorViewBackground(getWindow().getDecorView());
util.platform.colorViewBackground(binding.getRoot());
util.platform.colorTextButtons(binding.btnShareButton);
util.material.colorMaterialButtonPrimaryOutlined(binding.btnShareButton);
}

@Override
Expand Down
17 changes: 17 additions & 0 deletions app/src/main/res/drawable/ic_forward.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<!--
~ Nextcloud Notes - Android Client
~
~ SPDX-FileCopyrightText: 2018-2025 Google LLC
~ SPDX-License-Identifier: Apache-2.0
-->
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="24dp"
android:height="24dp"
android:autoMirrored="true"
android:tint="?attr/colorControlNormal"
android:viewportWidth="960"
android:viewportHeight="960">
<path
android:fillColor="@android:color/white"
android:pathData="M640,680L583,624L767,440L583,256L640,200L880,440L640,680ZM80,760L80,600Q80,517 138.5,458.5Q197,400 280,400L527,400L383,256L440,200L680,440L440,680L383,624L527,480L280,480Q230,480 195,515Q160,550 160,600L160,760L80,760Z" />
</vector>
18 changes: 9 additions & 9 deletions app/src/main/res/layout/activity_note_share.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,18 +93,18 @@

<com.google.android.material.button.MaterialButton
android:id="@+id/btnShareButton"
style="@style/Widget.Material3.Button.OutlinedButton"
android:layout_width="match_parent"
android:layout_height="wrap_content"
style="@style/Widget.Material3.Button.TextButton"
android:paddingStart="@dimen/spacer_3x"
android:paddingEnd="@dimen/zero"
android:text="@string/note_share_activity_share_note"
android:textAlignment="textStart"
android:layout_marginStart="@dimen/spacer_2x"
android:layout_marginEnd="@dimen/spacer_2x"
android:text="@string/note_share_activity_send_copy_to"
android:textColor="@color/text_color"
app:iconPadding="@dimen/share_button_padding"
app:iconTint="@color/text_color"
app:icon="@drawable/ic_share_white_24dp"
app:iconGravity="start" />
app:cornerRadius="@dimen/button_corner_radius"
app:icon="@drawable/ic_forward"
app:iconGravity="textStart"
app:iconPadding="@dimen/spacer_1x"
app:iconTint="@color/text_color" />

<LinearLayout
android:id="@+id/shared_with_you_container"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
<string name="note_share_activity_user_icon_content_description">note share user icon</string>
<string name="note_share_activity_contact_icon_content_description">note share contact icon</string>
<string name="note_share_activity_shared_with_you">Shared with you by %1$s</string>
<string name="note_share_activity_share_note">Share note</string>
<string name="note_share_activity_send_copy_to">Send copy to</string>
<string name="note_share_activity_search_text">Name, Federated Cloud ID or email address…</string>
<string name="note_share_activity_share_link">Share link</string>
<string name="note_share_activity_resharing_not_allowed">Policy or permissions prevent resharing</string>
Expand Down
Loading