Make external/app sharing within Android more clear and platform-aligned #2962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd platform-aligned Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2962.apk |
jancborchardt
approved these changes
Dec 18, 2025
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
As discussed I’d prefer if it’s at the end of the list (and probably our "share link" should be a button as well?) but that’s more difficult and can be tackled separately.
This is a nice improvement. :)
Member
Author
|
As discussed in the chat let's leave it as is for the moment, the other items are part of the list itself, so it is technically doable to also add this to the recycler view I think but additional work larger than just the simple visual change of the PR. Let's tackle it separately 👍 |
Member
Author
|
/backport to stable-4.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language mix is due to the lack of translations given it is a new string.
🖼️ Screenshots