-
Notifications
You must be signed in to change notification settings - Fork 12
Bring repo up to date #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @swissspidy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing and standardizing the repository's development and testing environment. It involves a significant overhaul of the testing setup by adopting the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on updating the testing infrastructure and applying code style fixes. The composer.json file was updated to require wp-cli/wp-cli version ^2.12 and replaced behat/behat with wp-cli/wp-cli-tests:^5.0 for development dependencies. It also introduced new Composer scripts for various testing and linting tasks (e.g., behat, phpcs, phpstan, phpunit). Correspondingly, all Behat-related files, including behat.yml, features/bootstrap/FeatureContext.php, features/bootstrap/Process.php, features/bootstrap/utils.php, features/extra/no-mail.php, and all files within features/steps/, were removed, indicating a complete migration to the new wp-cli-tests framework. A new phpcs.xml.dist file was added to configure PHP CodeSniffer with the WP_CLI_CS ruleset. Minor code style adjustments were made across inc/RestCommand.php and inc/Runner.php, primarily converting else if to elseif, fixing indentation, and standardizing string literal quotes, to align with the new coding standards.
Co-authored-by: Wojciech Smoliński <wojsmol@wp.pl>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
See #146