-
Notifications
You must be signed in to change notification settings - Fork 58
Preserve POT file order when updating PO files #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
8
commits into
main
Choose a base branch
from
copilot/fix-1570774-111592377-eba74e68-167e-426d-ae73-e6330b53d3e9
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Preserve POT file order when updating PO files #464
Copilot
wants to merge
8
commits into
main
from
copilot/fix-1570774-111592377-eba74e68-167e-426d-ae73-e6330b53d3e9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] update-po: Keep POT's order of translations
Preserve POT file order when updating PO files
Nov 3, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
swissspidy
reviewed
Nov 3, 2025
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
…426d-ae73-e6330b53d3e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Successfully implemented POT file order preservation in the
update-pocommand. The solution:Added
reorder_translations()method: After merging PO and POT translations, this method creates a new Translations object with entries ordered according to the POT file.Preserves all translation data: The solution maintains all translations, comments, metadata, and headers while only changing the order.
Works with all entry types: Tested with simple translations, plural forms, translations with contexts, translator comments, extracted comments, references, and new/existing translations.
Backward compatible: Existing tests will pass as the functionality remains the same, only the order changes.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.