Propagate ConflictExceptions properly #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgd
requested review from
PaulAsjes and
cadef
and removed request for
cadef
PaulAsjes
approved these changes
Nov 27, 2024
gcarvelli
approved these changes
Nov 27, 2024
| except ConflictException as ex: | ||
| assert str(ex) == "(message=No message, request_id=request-123)" | ||
| except Exception as ex: | ||
| assert ex.__class__ == ConflictException |
Contributor
There was a problem hiding this comment.
Do you know why we do these multiple-except blocks in this test file?
IIRC Python will only call the first matching except block so this except Exception block will never be entered.
Contributor
Author
There was a problem hiding this comment.
That's a great question. After changing the test it appears there's no reason really. Let me update these.
Contributor
Author
There was a problem hiding this comment.
Also confirming one of these tests failing doesn't look any different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Propagate ConflictExceptions properly and don't mask them as BadRequestExceptions.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.