Skip to content

[BUGIFX 176] Fix dbus connection leak #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
azsde wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BUGIFX 176] Fix dbus connection leak #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions omxplayer/player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,6 +863,10 @@ def quit(self):
"""
Quit the player, blocking until the process has died
"""
# Close dbus socket to avoid leaking unix socket.
if self._connection._bus is not None:
self._connection._bus.close()
logger.debug('BusConnection closed')
if self._process is None:
logger.debug('Quit was called after self._process had already been released')
return
Expand Down