Skip to content

Conversation

@faisal
Copy link
Contributor

@faisal faisal commented Dec 12, 2025

Bump Flay to 2.14, which switches to Prism for parsing.

Check list:

@faisal faisal marked this pull request as draft December 12, 2025 12:10
@faisal
Copy link
Contributor Author

faisal commented Dec 12, 2025

Looks like the true fix is in #551. Closing.

@faisal faisal closed this Dec 12, 2025
@faisal faisal reopened this Dec 12, 2025
@faisal
Copy link
Contributor Author

faisal commented Dec 12, 2025

This will fail until #548 is addressed.

@faisal
Copy link
Contributor Author

faisal commented Dec 12, 2025

Correction: this will not actually work until we resolve the incompatibility with Flog 4.9:

Because flay >= 2.14.0 depends on path_expander ~> 2.0
  and flog >= 4.4.0, < 4.9.0 depends on path_expander ~> 1.0,
  flay >= 2.14.0 is incompatible with flog >= 4.4.0, < 4.9.0.
And because every version of rubycritic depends on flay ~> 2.14.0,
  flog >= 4.4.0, < 4.9.0 is incompatible with rubycritic >= 0.
So, because every version of rubycritic depends on flog ~> 4.8.0
  and Gemfile depends on rubycritic >= 0,
  version solving has failed.

@faisal faisal closed this Dec 12, 2025
@faisal faisal deleted the fix_flay branch December 24, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant