fix(task-util): disable end button during conference with active consult #600
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fdb510975
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Agent-to-agent consult during conference: End button enabled when switched back to main call | ||
| if (isConsultInitiatedOrAcceptedOrBeingConsulted && isConferenceInProgress) { | ||
| return {isVisible, isEnabled: consultCallHeld}; | ||
| } | ||
|
|
||
| // Regular consult without conference: End button enabled only when on main call | ||
| if (isConsultInitiatedOrAcceptedOrBeingConsulted && !isConferenceInProgress) { | ||
| return {isVisible, isEnabled: consultCallHeld}; | ||
| return {isVisible, isEnabled: false}; |
There was a problem hiding this comment.
The comment says the end button is enabled when switched back to the main call during a consult conference, but the code now unconditionally disables it in that state. This mismatch can mislead future maintainers about the intended behavior and increases the chance of introducing regressions when modifying this logic; either update the comment or adjust the logic to match the documented intent.
Useful? React with 👍 / 👎.
2 participants
COMPLETES #CAI-7511
This pull request addresses
Inconsistent end call button visibility states from CC Desktop
by making the following changes
Modified state variables to mirror what is on the CC desktop
Vidcast: https://app.vidcast.io/share/906a7c3e-98a2-471f-be66-e4ec8a81cd53?playerMode=vidcast
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.