Skip to content

Conversation

@sitmsiteman
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture,
    • x86_64
    • x86_64-musl
  • I built this PR locally for these architectures (crossbuilds):
    • aarch64
    • aarch64-musl
    • armv7l
    • armv6l

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping template maintainers when you bump their packages. @the-maldridge

maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://github.com/libhangul/libhangul"
distfiles="https://github.com/libhangul/libhangul/archive/libhangul-${version}.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
distfiles="https://github.com/libhangul/libhangul/archive/libhangul-${version}.tar.gz"
distfiles="https://github.com/libhangul/libhangul/releases/download/libhangul-${version}/libhangul-${version}.tar.gz"

Then drop post_extract and pre_configure, replace automake gettext-devel libtool with gettext

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. That looks much better. I updated it.

@sitmsiteman sitmsiteman requested a review from ahesford January 7, 2026 12:46
@ahesford ahesford merged commit fa40506 into void-linux:master Jan 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants