Improvements for extraction tools (vmap/mmap) #3192
Conversation
schell244
changed the title
Will this still allow for running the extraction unsupervised/without manual input? That's important to me for scripting purposes. 😄 |
| bool highRes = preciseVectorData; | ||
| std::string userInput; | ||
| std::cout << "Extract vmaps with high resolution? [y/n]" << std::endl; | ||
| std::getline(std::cin, userInput); | ||
| highRes = userInput.empty() || userInput.compare("y") == 0; | ||
| std::cout << "High resolution = " << highRes << std::endl; | ||
| std::cout << "Press enter to start extracting vmaps." << std::endl; | ||
| std::cout << "=====================================" << std::endl; | ||
| std::cin.get(); | ||
|
|
||
| // Overwrite due to user input | ||
| preciseVectorData = highRes; | ||
|
|
There was a problem hiding this comment.
If you want to keep the prompts, to me it would also be fine to introduce a flag --non-interactive or something instead to be able to skip them.
There was a problem hiding this comment.
Thanks for pointing that out. I might just open a second PR, adding promts for both maps/vmaps similar to how it's currently done in the mmap tool 👍 (diff is already big enough here 😅)
There was a problem hiding this comment.
Would be very much appreciated if you want to give it a try 😇. A good point to check is .go c Glutton and see if he manages to walk through his 'narrow passage' – when Razorfen Leanto03 was broken, he just disappeared in the walls instead.
schell244
changed the title
2 participants
🍰 Pullrequest
The extractor was logging warnings for models referenced in DBC files
that don't actually exist in MPQ archives.
Added
MPQFileExists()check before attempting to open model files,so only actual extraction failures are reported.
Also removed the misleading "A few of these warnings are expected"
message since warnings now indicate real problems.
Add interactive prompts for vmap resolutionProof
Issues
How2Test
Todo / Checklist