Implement skip cache by URI path & response header #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r used to skip caching response - Updated docs to reference the new header
…caching for matching requests.
…sponse header) - Updated README to include examples for new ClientOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Firstly, this is a great package - thank you. I found that in the use case where someone might have wanted to skip caching particular responses or server paths intentionally, they were previously limited. With these proposed changes, users can specify a regex to restrict the cache's scope or set a previously defined header in their handler function to ensure the response is never cached (suitable for partially loaded site set-up, amongst other use cases).
What's Changed