feat(login): implement initial utility structure and configuration parser #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The unused warnings are deliberate - I'm trying to do only part of the work here. The compiling errors on Windows due to the bytes->file names ambiguity could be worked around (I could assume the login.defs file is utf8 and find an equivalent utf16 file name for Windows, or assume the whole file is encoded differently, or just the file paths). This seems pretty pointless though: I'm not sure which of these tools in shadow would be usable without Unix paths or at least something like WSL. |
…rser Implement the core infrastructure for the login utility, including command-line argument parsing and a comprehensive parser for the /etc/login.defs configuration file. - Add src/uu/login/src/login_defs.rs to parse login.defs configuration. - Implement `LoginDefs` struct with support for numeric and string fields. - Add extensive unit tests for configuration parsing, including error handling for permissions and invalid values. - Update src/uu/login/src/login.rs with `clap` arguments for standard flags (-p, -f, -h, -H). - Add `LoginConfiguration` to map CLI arguments. - Add basic root privileges check in `perform_login`. - Add basic integration test in tests/by-util/test_login.rs. - Update dependencies in `Cargo.toml`.
Remove Windows from matrices for check, test, clippy, and coverage. Windows has a completely different model for what "users" and "groups" are compared to *nix systems.
sargas
force-pushed
the
login-defs-definition
branch
from
9a8339a to
eabda9d
Compare
sargas
commented
Dec 11, 2025
| # spell-checker:ignore (libs) mangen procfs | ||
|
|
||
| [package] | ||
| name = "login" |
Author
There was a problem hiding this comment.
Much of this is reordered for consistency with uutils/coreutils's workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR establishes the foundational structure for the login utility, focusing primarily on parsing the
/etc/login.defsconfiguration file and setting up the basic command-line interface.This is the first step towards implementing parts of shadow-utils. The goal of this PR is to get the configuration loading and argument parsing logic in place so that subsequent PRs can focus on the actual authentication, PAM integration, and session management logic.
Key Changes
login_defs.rs)I've implemented a robust parser for login.defs that mirrors the behavior of shadow-utils. The parser collects warnings (e.g., file not found, permission errors, invalid values) instead of crashing, allowing login to fall back to safe defaults. It maps configuration keys to strongly typed fields (e.g.,
Option<u32>for timeouts,Option<PathBuf>for files). It handles most keys in shadow-utils'slogin.defs(5), including all the ones that seem required for login.Add clap argument parsing, along with a
LoginConfigurationstruct to hold parsed arguments.Added a preliminary check to ensure the
loginbinary is running with root privileges (or SUID), returning a standard "must be suid to work properly" error if not. This gave some behavior for a basic test case to be created.Most dependencies are updated except for uucore. Adopting this codebase to the current uucore appears to need some code changes due to the
help_aboutandhelp_usagemacros changing. A change tobuild.rswas needed; it appears to be part of Bumpphf_codegen& fix compilation error #169 and can be removed from this PR if that one is merged first.