Enable cat, sort, readlink and tr tests in busybox test suite #9850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Amazing, goes from 332 to 356 passing, no more new failing tests added either |
|
GNU testsuite comparison: |
ChrisDryden
force-pushed
the
busybox-enable-cat-sort-tests
branch
from
edd5f8f to
e2627bd
Compare
Collaborator
Author
|
I'd love to add a similar tracker with a comment for the Busybox tests to track when new tests begin passing, the only tricky part is investigating further into the tests it appears that some are tests are validating functionality that is just incompatible with the GNU implementation. Would be nice if we could mark which one of the tests are expected to fail. |
Collaborator
Author
|
enabled the readlink and tr tests and now its 363 passing! |
|
GNU testsuite comparison: |
ChrisDryden
changed the title
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying to see why some of the busybox tests were being skipped and it seems that we're just missing some flags. Testing it out in the CI