sort: refine error handling and localize field parsing errors #10068
+458
−261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsu2020
force-pushed
the
pr1-sort-errors-i18n
branch
from
0f2d04d to
0fa58d0
Compare
- Add 'dfgi' to spell-checker ignore list for accurate linting - Reformat tuple and method call in test_conflict_check_out for consistency and to resolve clippy warnings
|
GNU testsuite comparison: |
Contributor
|
a few jobs are failing |
… error handling - Changed `ModeFlags::default()` to `Self::default()` for better idiomatic Rust code. - Removed `.into()` call in `FieldSelector::from` method as it was redundant, simplifying error construction.
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notes