Database cleanup selects queries

[fogelito]

Summary by CodeRabbit

• Chores
  • Optimized database cleanup operations with improved query efficiency through simplified field selection and focused time-based filtering.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The cleanup method in the Database adapter has been modified to simplify its delete query construction. The explicit selection of specific document fields ($sequence, $id, $collection, $permissions, $updatedAt, time) has been removed from the query builder. A comment block has been added noting a planned future transition to individual selected queries. The delete query now applies only time-based filtering and ordering without the prior field visibility logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is vague and doesn't clearly convey the main purpose of the changes. It uses generic phrasing that doesn't indicate what the database cleanup is actually accomplishing.	Consider a more descriptive title such as 'Remove explicit field selection from database cleanup query' or 'Simplify database cleanup to use time-based filtering only'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5b667c and 6805570.

📒 Files selected for processing (1)

• src/Audit/Adapter/Database.php

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/Audit/Adapter/Database.php (1)

387-395: Query::orderAsc() requires a field argument per the Query API.

The documented API for Query::orderAsc() expects an attribute parameter (e.g., Query::orderAsc('time')). Line 394 calls Query::orderAsc() without an argument, which is inconsistent with the documented behavior and differs from the ordered queries used elsewhere in the file (lines 154, 210, 271, 335).

For the cleanup operation, either specify the field explicitly—Query::orderAsc('time')—or remove this call if no secondary sort is intended.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5b667c and 6805570.

📒 Files selected for processing (1)

• src/Audit/Adapter/Database.php

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}