Checkout with cone mode #25
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the sparse-checkout-cone-mode: false parameter from GitHub Actions checkout configurations, transitioning to use cone mode (the default) for sparse checkouts in workflow files. This change affects PHP-related workflows that perform partial repository checkouts to optimize CI/CD performance.
Key Changes:
- Removed
sparse-checkout-cone-mode: falsefrom three checkout action configurations - Changes affect workflows that use sparse checkout for
composer.jsonandcomposer.lockfiles - Aligns with cone mode as the default sparse-checkout behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/lint-php.yml | Removed cone mode override for composer.json sparse checkout in php-matrix job |
| .github/workflows/audit-php.yml | Removed cone mode override for composer.json sparse checkout in php-matrix job and for composer.json/composer.lock sparse checkout in composer-audit job |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with: | ||
| sparse-checkout: | | ||
| composer.json | ||
| composer.lock |
There was a problem hiding this comment.
Removing sparse-checkout-cone-mode: false may cause issues with checking out composer.json and composer.lock. In cone mode (the new default), sparse-checkout patterns are treated as directory paths, not file patterns. This means these files may not be checked out as expected.
To check out specific files in cone mode, you typically need to either:
- Keep
sparse-checkout-cone-mode: falseto use non-cone mode (original behavior) - Change the pattern to include the parent directory (e.g., use
/to checkout the root and then specify files)
| composer.lock | |
| composer.lock | |
| sparse-checkout-cone-mode: false |
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| sparse-checkout: composer.json |
There was a problem hiding this comment.
Removing sparse-checkout-cone-mode: false may cause issues with checking out composer.json. In cone mode (the new default), sparse-checkout patterns are treated as directory paths, not file patterns. This means composer.json may not be checked out as expected.
To check out a specific file in cone mode, you typically need to either:
- Keep
sparse-checkout-cone-mode: falseto use non-cone mode (original behavior) - Change the pattern to include the parent directory (e.g., use
/to checkout the root and then specify files)
The same issue applies to the other occurrences in audit-php.yml.
| sparse-checkout: composer.json | |
| sparse-checkout: composer.json | |
| sparse-checkout-cone-mode: false |
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| sparse-checkout: composer.json |
There was a problem hiding this comment.
Removing sparse-checkout-cone-mode: false may cause issues with checking out composer.json. In cone mode (the new default), sparse-checkout patterns are treated as directory paths, not file patterns. This means composer.json may not be checked out as expected.
To check out a specific file in cone mode, you typically need to either:
- Keep
sparse-checkout-cone-mode: falseto use non-cone mode (original behavior) - Change the pattern to include the parent directory (e.g., use
/to checkout the root and then specify files)
| sparse-checkout: composer.json | |
| sparse-checkout: composer.json | |
| sparse-checkout-cone-mode: false |
No description provided.