-
Notifications
You must be signed in to change notification settings - Fork 0
Lint GitHub Actions #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new GitHub Actions workflow to lint GitHub Actions workflow files using actionlint. The workflow is designed to run on pull requests and pushes to the main branch, as well as being callable as a reusable workflow, helping ensure workflow files follow best practices and are free of common errors.
- Adds automated linting for GitHub Actions workflows
- Configures actionlint with color output
- Sets appropriate read-only permissions for the workflow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@tangrufus I've opened a new pull request, #24, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
.github/workflows/lint-action.yml:32
- These debugging steps (
pwdandls -la) should be removed before merging. They appear to be temporary commands used during development and are not necessary for the workflow's functionality.
- run: pwd
- run: ls -la .github/workflows
- name: Check workflow files
run: actionlint -color
.github/workflows/lint-action.yml:36
- [nitpick] The comment "Repo name." is unclear and doesn't explain why
working-directory: .githubis specified. Consider either removing this comment or clarifying its purpose. Additionally, note thatworking-directory: .githubmay not be necessary here since actionlint should be able to detect workflow files in.github/workflows/from the repository root.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.