add GRANT ROLE, REVOKE ROLE, and ALTER DEFAULT PRIVILEGES completions #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpholt
commented
Dec 12, 2025
| def sessionTest[A](name: String, readTimeout: Duration = Duration.Inf)(fa: Session[IO] => IO[A])(implicit loc: Location): Unit = | ||
| test(name)(session(readTimeout).use(fa)) | ||
|
|
||
| def sessionTestWithCleanup[A](name: String, |
Member
Author
There was a problem hiding this comment.
I got annoyed that the DROP ROLE commands that clean up many of the command tests don't run if the test fails, so I added this new method to run the cleanup steps in a guarantee block. If we like this, we can move others to this style over time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1237.
BTW, I wonder if this Postgres source file contains the full list of command completions? If so, we could use that as a source to try to add any remaining completions we're missing.