feat: add public notes sharing with security hardening #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to publish notes as public, shareable pages while maintaining security for the E2E encrypted notes application. Features: - Publish/unpublish notes via modal with optional author attribution - Public page at /p/:slug with full TipTap rendering support - Globe icon indicator on tabs and note cards for published notes - "Public" view in sidebar to filter published notes - Auto-sync: edits to notes automatically update public version - Theme toggle (light/dark) on public page, defaults to system - Collapsible table of contents support - SEO meta tags (Open Graph, Twitter Cards) Security: - DOMPurify sanitization on both frontend and backend (defense in depth) - Strip internal note IDs from public content - Clear warning that publishing bypasses E2E encryption - Unguessable slugs (nanoid, 839 quadrillion combinations) - Hard delete on unpublish (no soft delete) - Rate limiting on public endpoints - No auth tokens or sensitive data exposed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 1.41.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
New Files
src/pages/PublicNotePage.tsx- Public note viewer with TipTap renderingsrc/components/editor/modals/PublishNoteModal.tsx- Publish/unpublish dialogModified
dompurifydependency for XSS protectionTabBarandNoteCardwith Globe icon for published notesuseNoteshook with publish/unpublish operationsSecurity
Test plan