Skip to content

feat(snowflake)!: Type annotation for COVAR_POP and COVAR_SAMP #6656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VaggelisD merged 1 commit into from
Jan 5, 2026
+20 −2
Merged

feat(snowflake)!: Type annotation for COVAR_POP and COVAR_SAMP #6656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sqlglot/expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8332,11 +8332,11 @@ class WidthBucket(Func):


class CovarSamp(Binary, AggFunc):
pass
arg_types = {"this": True, "x": False}


class CovarPop(Binary, AggFunc):
pass
arg_types = {"this": True, "x": False}


class Week(Func):
Expand Down
2 changes: 2 additions & 0 deletions sqlglot/typing/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,8 @@ def _annotate_str_to_time(self: TypeAnnotator, expression: exp.StrToTime) -> exp
exp.Cbrt,
exp.Cosh,
exp.CosineDistance,
exp.CovarPop,
exp.CovarSamp,
exp.DotProduct,
exp.EuclideanDistance,
exp.ManhattanDistance,
Expand Down
16 changes: 16 additions & 0 deletions tests/fixtures/optimizer/annotate_functions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1776,6 +1776,22 @@ DOUBLE;
CBRT(tbl.double_col);
DOUBLE;

# dialect: snowflake
COVAR_POP(tbl.double_col, tbl.double_col);
DOUBLE;

# dialect: snowflake
COVAR_SAMP(tbl.double_col, tbl.double_col);
DOUBLE;

# dialect: snowflake
COVAR_POP(tbl.double_col, tbl.double_col) OVER (PARTITION BY 1);
DOUBLE;

# dialect: snowflake
COVAR_SAMP(tbl.double_col, tbl.double_col) OVER (PARTITION BY 1);
DOUBLE;

# dialect: snowflake
AI_AGG('foo', 'bar');
VARCHAR;
Expand Down