Fix(optimizer): preserve position metadata during star expansion #6647
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where columns generated via star expansion (e.g.,
SELECT *) or output qualification lost their original position metadata (line,col,start,end).This metadata is essential for static analysis tools, linters, and error reporting to correctly point back to the source location of a column.
Changes
_expand_stars: Modified to copy metadata from the originalStarexpression to the newly expandedColumnexpressions.qualify_outputs: Updated to ensure metadata is preserved when wrapping expressions in anAlias.Example
Input SQL:
Before:
Generated columns had valid names but lost their location info:
After:
Generated columns inherit location info from the star:
Reproduction Script