Skip to content

Conversation

@sofiane-soufi
Copy link
Contributor

No description provided.

@sofiane-soufi sofiane-soufi marked this pull request as ready for review January 22, 2026 03:54
* Leverages the same underlying wire format as strings until
* native JSON serialization support is available server-side.
*/
class ColumnJson : public ColumnString {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can create a feature request to support json column to avoid this backward compatibility issue in future

@yuzifeng1984 may you take a look if we can support json native type in this client.

@sofiane-soufi btw, may i ask what's your current use cases you need json type in this client ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall correctly, some streams had JSON column types, and querying them from the client would result in errors and no results due to missing JSON column support.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous json PR 23 is for old protocol and seems not working with current timeplus. I will be looking at how to fix the protocol. Using string column to send is fine while may have problem in decoding server json column data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants