fix: replace decode-entity.browser.js for Web Workers #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I've found what appears to be a small bug, so I'd like to report it.
Problem
In
textlint/editor, if a named entity reference (e.g.>) is entered, the error "document is not defined" occurs.Numeric entity references, however, work fine.
Screen Shot:
Error message and Stacktrace:
Source:
This error seems to originate from
parse-entities.The latest version of parse-entities is 4.0.2, but
textlint/editorcurrently uses 2.0.0, which appears to switch between the browser and non-browser versions.textlint/editorimports the browser version ofparse-entities, which depends ondocument. However, sincetextlint/editorruns the relevant code inside a Web Worker,documentis not available, leading to the error.Proposed Solution
Possible solutions could include:
parse-entitiesparse-entitiesFor this pull request, I modified
src/compiler.tsin@textlint/script-compilerto use the non-browser version, and added a Webpack plugin configuration.With this change, we confirmed that the error no longer occurs when entering named entity references.
That said, we haven’t yet conducted extensive testing.