fix(github): trim whitespace from action references #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, MCP tool calls created orphaned spans without parent
transactions, causing Sentry to display '<unlabeled transaction>'
instead of meaningful transaction names.
This change updates the tracing implementation to create proper
transactions following OpenTelemetry MCP Semantic Conventions:
- Transaction name: 'tools/call {tool_name}'
- Operation: 'mcp.server'
- Proper hub management to ensure context propagation
- All MCP attributes correctly attached to transactions
Resolves the issue of unlabeled transactions appearing in Sentry,
making MCP tool analytics properly visible and filterable by tool name.
Fixes issue where action references with trailing newlines or other whitespace characters would fail with URL parsing errors. The ParseActionRef function now trims all leading and trailing whitespace (spaces, tabs, newlines) before parsing the action reference. Added comprehensive unit tests covering: - Trailing newlines - Leading and trailing whitespace - Tabs and newlines - Edge cases (empty strings, whitespace-only strings)
philprime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where action references with trailing newlines or other
whitespace characters would fail with URL parsing errors.
The ParseActionRef function now trims all leading and trailing
whitespace (spaces, tabs, newlines) before parsing the action reference.
Added comprehensive unit tests covering: