Skip to content

fix: Use setState callback in finishDrop to avoid occasional flicker #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lyxell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Use setState callback in finishDrop to avoid occasional flicker #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-poems-shake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-movable": patch
---

Use setState callback in finishDrop to avoid occasional flicker
48 changes: 25 additions & 23 deletions src/List.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,31 +484,33 @@ class List<Value = string> extends React.Component<IProps<Value>> {
? -1
: Math.max(this.afterIndex, 0)
: oldIndex;
if (removeItem || hasChanged) {
this.props.onChange({
oldIndex,
newIndex,
targetRect: this.ghostRef.current!.getBoundingClientRect(),
});
}
this.props.afterDrag &&
this.props.afterDrag({
elements: this.getChildren(),
oldIndex,
newIndex,
const targetRect = this.ghostRef.current!.getBoundingClientRect();
this.setState({ itemDragged: -1, scrollingSpeed: 0 }, () => {
if (removeItem || hasChanged) {
this.props.onChange({
oldIndex,
newIndex,
targetRect: targetRect,
});
}
this.props.afterDrag &&
this.props.afterDrag({
elements: this.getChildren(),
oldIndex,
newIndex,
});
this.getChildren().forEach((item) => {
setItemTransition(item, 0);
transformItem(item, null);
(item as HTMLElement).style.touchAction = "";
});
this.getChildren().forEach((item) => {
setItemTransition(item, 0);
transformItem(item, null);
(item as HTMLElement).style.touchAction = "";
this.afterIndex = -2;
// sometimes the scroll gets messed up after the drop, fix:
if (this.lastScroll > 0) {
this.listRef.current!.scrollTop = this.lastScroll;
this.lastScroll = 0;
}
});
this.setState({ itemDragged: -1, scrollingSpeed: 0 });
this.afterIndex = -2;
// sometimes the scroll gets messed up after the drop, fix:
if (this.lastScroll > 0) {
this.listRef.current!.scrollTop = this.lastScroll;
this.lastScroll = 0;
}
};

onKeyDown = (e: React.KeyboardEvent) => {
Expand Down