android: drop health warnings in Stopped and NeedsLogin state #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kari-ts
reviewed
Jan 23, 2026
| // When the client is Stopped, requires Login or has no state, we should drop all | ||
| // existing warnings | ||
| when (val ipnState = pair.second) { | ||
| Ipn.State.NeedsLogin, |
Collaborator
There was a problem hiding this comment.
I think this isn't relevant to Android, but what about InUseOtherUser?
Member
Author
There was a problem hiding this comment.
I copied the logic from the Apple notifier. InOtherUser isn't covered there - I don't think it's relevant on mobile (or at least, not relevant here). NeedsLogin was the state we weren't dealing with IIRC. I'll double check. It's possible we were just transitioning through NoState too - which dropped the warnings.
barnstar
force-pushed
the
jonathan/drop-health-when-not-logged-in
branch
3 times, most recently
from
29bb6bc to
629432e
Compare
fixes tailscale/corp#36233 We should be dropping health warnings when we're not in the Running state. This also adds some functionality to inject fake health warnings to make it possible to trigger these without triggering a real health condition. Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
barnstar
force-pushed
the
jonathan/drop-health-when-not-logged-in
branch
from
629432e to
814fdc7
Compare
kari-ts
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes tailscale/corp#36233
We should be dropping health warnings when we're not in the Running state.