feat(citations): Add support for web and search result citations #1344
+97
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilop
requested a deployment
to
manual-approval
GitHub Actions
Waiting
8 tasks
dbschmigelski
force-pushed
the
feat/web-citations
branch
from
4da59c6 to
0f7392c
Compare
dbschmigelski
had a problem deploying
to
manual-approval
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
zastrowm
approved these changes
Dec 19, 2025
dbschmigelski
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
mkmeral
approved these changes
Dec 19, 2025
JackYPCOnline
pushed a commit
to CrysisDeu/sdk-python
that referenced
this pull request
Dec 19, 2025
…#1344) Co-authored-by: Dean Schmigelski <dbschmigelski+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for web-based and search result citations in the Bedrock Converse API, completing support for all citation location types.
New Features:
WebLocationtype for web-based citations (url, domain)SearchResultLocationtype for search result citations (searchResultIndex, start, end)_format_citation_locationto handle all 5 location typesOnce #1154 is merged, this feature will allow Anthropic Bedrock models to return citations generated using server side tools. Of course, for custom model implementations, builders can begin using this immediately.
Dependencies
This PR depends on #1343 (fix: Preserve tagged union structure for CitationLocation) which must be merged first.
Related Issues
Fixes #1345
Type of Change
New feature
Testing
hatch run prepare(1618 tests pass)Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.