Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Contracts/ValidationRule.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static function id(): string;
*
* @since 1.0.0
*/
public static function fromString(string $options = null): ValidationRule;
public static function fromString(?string $options = null): ValidationRule;

/**
* The invokable method used to validate the value. If the value is invalid, the fail callback should be invoked
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/Abstracts/ConditionalRule.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function __construct($conditions)
*
* @since 1.2.0
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
if (empty($options)) {
Config::throwInvalidArgumentException(static::class . ' rule requires at least one condition');
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/Boolean.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public static function id(): string
*
* @since 1.4.0
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new self();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/Currency.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static function id(): string
*
* @since 1.0.0
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new self();
}
Expand Down
4 changes: 2 additions & 2 deletions src/Rules/DateTime.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@ public static function id(): string
/**
* @since 1.2.0
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new static($options);
}

/**
* @since 1.2.0
*/
public function __construct(string $format = null)
public function __construct(?string $format = null)
{
$this->format = $format;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/Email.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public static function id(): string
*
* @since 1.0.0
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new self();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/Exclude.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public static function id(): string
*
* @since 1.2.0
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new self();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/In.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ final public function __construct(...$acceptedValues)
/**
* @since 1.2.0
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
if (empty(trim($options))) {
Config::throwInvalidArgumentException('The In rule requires at least one value to be specified.');
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/Integer.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public static function id(): string
/**
* @inheritDoc
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new self();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/Max.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public static function id(): string
*
* @since 1.0.0
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
if (!is_numeric($options)) {
Config::throwInvalidArgumentException('Max validation rule requires a numeric value');
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/Min.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public static function id(): string
*
* @since 1.0.0
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
if (!is_numeric($options)) {
Config::throwInvalidArgumentException('Min validation rule requires a numeric value');
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/Nullable.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public static function id(): string
/**
* @since 1.1.0
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new self();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/Numeric.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static function id(): string
*
* @since 1.0.0
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new self();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/Optional.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public static function id(): string
/**
* @since 1.1.0
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new self();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/Required.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public static function id(): string
/**
* @inheritDoc
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new self();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Rules/Size.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public static function id(): string
*
* @since 1.0.0
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
if (!is_numeric($options)) {
Config::throwInvalidArgumentException('Size validation rule requires a numeric value');
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/ValidatorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ public static function id(): string
return 'skip';
}

public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new self();
}
Expand All @@ -301,7 +301,7 @@ public static function id(): string
/**
* @inheritDoc
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new self();
}
Expand Down Expand Up @@ -330,7 +330,7 @@ public static function id(): string
/**
* @inheritDoc
*/
public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new self();
}
Expand Down Expand Up @@ -361,7 +361,7 @@ public static function id(): string
return 'exclude';
}

public static function fromString(string $options = null): ValidationRule
public static function fromString(?string $options = null): ValidationRule
{
return new self();
}
Expand Down