[5.x] Fix eloquent:import-users command with computed values
#13260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the
eloquent:import-userscommand when computed values exist for users.The command would complain that there's "No users to import". Calling
app(UserRepository::class)->all()directly would return the flat-file user, butUser::all()wouldn't.The reason for this is because the Eloquent repository is resolved/cached by the facade from when the computed value was registered in the
AppServiceProvider.This PR fixes it by clearing resolved instances of the
Userafter we bind the flat file repository.Fixes #13214