Skip to content

Conversation

@marceljk
Copy link
Contributor

@marceljk marceljk commented Nov 28, 2025

Description

relates to #1125

Testing instructions

  1. Checkout the branch of this PR and run $ make build
  2. Set the session limit to 1s, to simulate an expired session
    $ ./bin/stackit config set --session-time-limit 1s
  3. Authenticate with your user account
    $ ./bin/stackit auth login
  4. Run a command with output format json, e.g.:
    $ ./bin/stackit network list -o json | jq
    -> should work
  5. Checkout the main branch and rerun the previous command
    $ ./bin/stackit network list -o json | jq
    -> should fail

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner November 28, 2025 15:49
Copy link
Contributor

@cgoetz-inovex cgoetz-inovex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, manual test successfull

@marceljk marceljk force-pushed the fix/logging-browser-auth-url branch from 0e74f2a to 6f9d56c Compare November 28, 2025 16:13
@marceljk marceljk enabled auto-merge (squash) November 28, 2025 16:13
@marceljk marceljk merged commit 58a4b77 into main Nov 28, 2025
5 checks passed
@marceljk marceljk deleted the fix/logging-browser-auth-url branch November 28, 2025 16:19
@github-actions
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/pkg/auth 56.52% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/pkg/auth/user_login.go 9.89% (ø) 182 18 164

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

cgoetz-inovex added a commit that referenced this pull request Jan 27, 2026
* feat(cdn): add cdn client, config, list command

* fix(cdn): generate docs

* fix(cdn) fix linting issues

* Update internal/cmd/beta/cdn/distribution/list/list.go

Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>

* Update internal/cmd/beta/cdn/distribution/list/list.go

Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>

* fix(cdn): rename sortBy params, use EnumSliceToStringSlice

* fix(cdn): make `testNextPageID`, `testID` and `testStatus` constant

* fix(cdn): add cdn subcommand to beta, generate docs

* feat(cdn) add limit flag to distribution list

* feat(cdn): add distribution create cmd

* fix(cdn): generate distribution create docs

* squash this

* feat(cdn) implement cdn distribution create/delete/describe/update

* squash

* squash

* fix(cdn) regenerate docs

* fix(cdn) linting issues

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/secretsmanager (#1112)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/serverbackup (#1111)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/ske (#1110)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/serverupdate (#1109)

* chore(deps): bump renovatebot/github-action from 44.0.3 to 44.0.4 (#1113)

* feat(kms) describe key, keyring, wrappingkey (#1107)

* feat(kms) describe key, keyring, wrappingkey

* fix(kms): do not reuse buffer during output tests

* fix(kms) use constant Time for TestOutputResult for constant table widths

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/rabbitmq (#1118)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/alb (#1117)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/mongodbflex (#1116)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/serviceaccount (#1115)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/serviceenablement (#1123)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/dns (#1122)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/iaas (#1121)

* fix(alb): print valid JSON/YAML output for list cmds (#1045)

relates to STACKITCLI-273 / #893

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/mariadb (#1129)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/redis (#1128)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/runcommand (#1127)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/authorization (#1120)

* chore: increase linter timeout (#1131)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/intake (#1132)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/loadbalancer (#1133)

* fix: log browser url to stderr instead of stdout (#1136)

fixes #1125

* fix(deps): update module github.com/goccy/go-yaml to v1.19.0 (#1137)

* feat(mongodbflex): add readAnyDatabase and stackitAdmin roles for users (#1049)

Co-authored-by: Ruben Hoenle <Ruben.Hoenle@stackit.cloud>

* fix: refresh token flow uses x-www-form encoding (#1135)

* chore(deps): update renovatebot/github-action action to v44.0.5 (#1141)

* chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/sqlserverflex (#1139)

* feat(cdn): add cdn client, config, list command

* feat(cdn) implement cdn distribution create/delete/describe/update

* fix(cdn) manual merge fixes

* fix(cdn) review fixes

- test Min
- test JoinStringMap
- rm superfluous var for constant
- rm file committed by accident
- add nil checks when dereferencing pointers

* fix(cdn) replace utils.Min usage with builtin min

* Update internal/cmd/beta/cdn/distribution/list/list.go

Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>

* fix(cdn) apply review comments

- replace single char names with more descriptive ones
- remove predefined mod functions
- deduplicate ParseOriginRequestHeaders and test it
- deduplicate ParseGeofencing and test it
- add test FlagTo* funcs

* fix(cdn) fix merge errors

* fix(cdn) more merge errors, and single char renames

* fix(cdn) JoinStringMap: define order

* fix(cdn) define geofencing order

* fix(cdn) review changes

- fix `ID` spelling
- add missing new line at end of output
- rm TODO comment

* feat(printer) make PromptForPassword scripting compatible

* fix(cdn) add example to pass password in script

* fix(docs) generate docs

* fix(printer) make TestPromptForPassword compatible with older go versions

* fix(printer) fix/ignore linting issues

* fix(cdn) adjust list TestOutputResult expected to new printer changes

* fix(cdn) rm superfluous model.AssumeYes checks

* fix(fmt) run fmt

---------

Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>
Co-authored-by: stackit-pipeline <142982727+stackit-pipeline@users.noreply.github.com>
Co-authored-by: Piet van der Meulen <piet.van.der.meulen@freiheit.com>
Co-authored-by: Jorge Turrado Ferrero <jorge.turrado@mail.schwarz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants