Remove some redundant GL validation. #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
null77
force-pushed
the
remove-extra-validation
branch
from
03ff51d to
4fba562
Compare
Author
|
Added a new push which removes some extra texture validation, helper functions, and validation in draw calls. |
ANGLE itself can manage most of WebGL validation. This makes the transition to WebGL 2 validation easier because we won't need to write new logic for all the new entry points. To this effect this enables robust memory features in ANGLE, and also updates the error set logic. This contribution is funded by http://higharc.com/
null77
force-pushed
the
remove-extra-validation
branch
from
4fba562 to
df9d965
Compare
Author
|
Another small update with some extra validation removed for ANGLE_instanced_arrays. |
Member
|
Passes locally against the to-be-published gl-conformance test package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANGLE itself can manage most of WebGL validation. This makes the transition to WebGL 2 validation easier because we won't need to write new logic for all the new entry points.
To this effect this enables robust memory features in ANGLE, and also updates the error set logic.
This contribution is funded by http://higharc.com/
@dhritzkiv this is the next functional change. Still passes all tests with the updated gl-conformance for me locally on Windows.