-
Notifications
You must be signed in to change notification settings - Fork 2
fix: Prevent Pod 0 restart by utilizing mutating webhook #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Many parts copied from https://github.com/stackabletech/commons-operator/tree/spike/sts-restarter-webhook Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
My tests worked as expected. One thing I found was that with airflow-operator the behavior is still the same (Pod 0 gets restarted), I believe this is because airflow-operator creates the ConfigMap after the StatefulSet: https://github.com/stackabletech/airflow-operator/blob/39d98ecd67a7bf29753551e01217faefafb53220/rust/operator-binary/src/airflow_controller.rs#L604-L628
So this could be a follow-up PR for airflow-operator. With superset-operator it worked fine.
Correct, we will change that :) |
Co-authored-by: Lukas Krug <lukas.krug@stackable.tech>
|
Can you clarify the release notes for me? What is "pod 0"? Why does a mutating webhook help? Again: If you have or are planning to address this in the parent then that's fine. |
Description
Fixes #111
Many parts copied from https://github.com/stackabletech/commons-operator/tree/spike/sts-restarter-webhook
This bumps to operator-rs 0.101.1, but we don't have any objectOverrides to implement here.
Co-authored-by: Natalie Klestrup Röijezon nat@nullable.se
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features trackerRelease notes
Fixed
The commons-operator now needs the RBAC permission to
createandpatchmutatingwebhookconfigurations, which the helm-chart automatically adds.The webhook can be disabled using
--disable-restarter-mutating-webhookor by setting theDISABLE_RESTARTER_MUTATING_WEBHOOKenv variable.