Skip to content

Conversation

@yadij
Copy link
Contributor

@yadij yadij commented Dec 18, 2025

Only add comments when the labels actually changed.
The GH tool still needs to be updated to restore proper
behaviour.

@yadij yadij requested review from kinkie and rousskov December 18, 2025 01:24
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, this script incorrectly ignores other [gh] failures as well. I also sense a disconnect/mismatch between failing to remove a label and the subsequent PR creation attempts that ignore that and other failures. There are other inconsistencies/puzzles as well. Said that, the proposed fix is probably a step forward.

@rousskov
Copy link
Contributor

The GH tool still needs to be updated to restore proper behaviour.

FWIW, I do not know what that comment in PR description means/implies.

@kinkie
Copy link
Contributor

kinkie commented Dec 18, 2025

The GH tool still needs to be updated to restore proper behaviour.

FWIW, I do not know what that comment in PR description means/implies.

It's comments like squid-cache/squid#2314 (comment)

@rousskov
Copy link
Contributor

The GH tool still needs to be updated to restore proper behaviour.

FWIW, I do not know what that comment in PR description means/implies.

It's comments like squid-cache/squid#2314 (comment)

AFAICT, you are giving an example of a GitHub comment that PR-affected code is producing. I understand what those GitHub comments are. I do not understand the specific PR description paragraph that I have quoted.

@yadij
Copy link
Contributor Author

yadij commented Dec 28, 2025

The GH tool still needs to be updated to restore proper behaviour.

FWIW, I do not know what that comment in PR description means/implies.

It's comments like squid-cache/squid#2314 (comment)

AFAICT, you are giving an example of a GitHub comment that PR-affected code is producing. I understand what those GitHub comments are. I do not understand the specific PR description paragraph that I have quoted.

For the non-error process to work as intended, the gh binary that these scripts runs needs to also be upgraded. Otherwise we will just continue to have label errors, but without the duplicate comments.

I have done that upgrade in the background, which is why the comments stopped happening already before this PR merge. As I write this the script error handling is still broken, but not triggered by the latest binary.

@yadij yadij merged commit fe72552 into main Dec 28, 2025
1 check passed
@yadij yadij deleted the yadij-patch-5 branch December 28, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants