Fix CASE expression alias handling and enable 2 passing tests #46
+27
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add QuotedAlias field to CaseExpr to track double-quoted aliases - Add Quoted field to lexer Item to identify quoted identifiers - Only output CASE/multiIf aliases when they were unquoted in the source - This matches ClickHouse's EXPLAIN AST behavior where quoted aliases like AS "NAME" are not shown, but unquoted aliases like AS name are - Enable 00551_parse_or_null and 02910_nullable_enum_cast tests which now pass with the improved alias handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like AS "NAME" are not shown, but unquoted aliases like AS name are
now pass with the improved alias handling