Fix parser tests with various EXPLAIN AST formatting improvements #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key fixes: - WITH FILL: Use FillModifier for complex expressions, direct children for simple literals - IN expressions: Add threshold (10 items) for tuple combining of string lists - CAST expressions: Correct Array format based on target type - Array(String) uses Array_[...] format - Array(JSON), Array(LowCardinality(String)) use string format - Add IN expression alias support Enabled tests: - 02017_order_by_with_fill_redundant_functions - 01497_now_support_timezone - 00066_group_by_in and 00676_group_by_in - 02537_system_formats - 02771_if_constant_folding - 01421_assert_in_in - 03550_variant_extend_union - 02561_with_fill_date_datetime_incompatible - 03405_json_parsing_error_bug - 02313_dump_column_structure_low_cardinality - Multiple other WITH FILL and IN expression tests Marked 02111_with_fill_no_rows as todo due to conflicting expected output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key fixes:
Enabled tests:
Marked 02111_with_fill_no_rows as todo due to conflicting expected output