Refine default enablement of gRPC health service #335
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I will also add documentation where I will describe that server-side health in our case is disabled by default. |
Contributor
|
👋🏻 @therepanic , thanks for the quick turnaround. However, we would like to have a team chat about this change before proceeding. We will get back w/ you shortly. |
Member
|
It's more complicated than my comment in #334 implied. We don't want the health checks to be disabled by default if there actually is a |
Contributor
Author
|
You mean it should work like this?
|
Member
|
Precisely |
Contributor
Author
|
Okay, I'll be back soon with some polished changes. |
Enable gRPC health by default only when a BindableService is present. Respect explicit spring.grpc.server.health.enabled overrides and add tests. Closes: spring-projectsgh-334 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
changed the title
Contributor
Author
|
I've slightly reworked my changes. They now incorporate the logic described above. I've also documented it. |
Document that server-side gRPC health is enabled by default only when a BindableService is present. Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
BindableServicebean condition from gRPC health auto-configuration. Make server-side health opt-in by defaultspring.grpc.server.health.enabled=false. This allows exposing the health service as the only gRPC service without starting a server unexpectedly unless enabled.Closes: gh-334