Skip to content

Add some decoding size limits #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tigrannajaryan wants to merge 1 commit into
base: tigran/reader-fuzz-tests
Choose a base branch
from
Open

Add some decoding size limits #301

tigrannajaryan wants to merge 1 commit into from

Conversation

@tigrannajaryan
Copy link
Collaborator

@tigrannajaryan tigrannajaryan commented Dec 18, 2025 •
edited
Loading

  • Set limit on column sizes
  • Add varheader size limits

Without limits we were potentially trying to do huge allocations. Fuzz tests caught these.

@tigrannajaryan tigrannajaryan marked this pull request as ready for review December 18, 2025 20:38
@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Benchmark Result

Benchmark diff with base branch 
goos: linux
goarch: amd64
pkg: github.com/splunk/stef/benchmarks
cpu: AMD EPYC 7763 64-Core Processor                
                                                 │ bench-main.txt │            bench-new.txt            │
                                                 │     sec/op     │    sec/op     vs base               │
SerializeNative/STEF/serialize-4                     7.874m ±  3%   7.595m ±  4%   -3.55% (p=0.041 n=6)
SerializeNative/STEFU/serialize-4                    34.38m ±  7%   35.10m ±  1%        ~ (p=0.093 n=6)
DeserializeNative/STEF/deser-4                       2.506m ±  0%   2.413m ±  4%   -3.72% (p=0.015 n=6)
DeserializeNative/STEFU/deser-4                      7.158m ±  0%   7.196m ±  1%   +0.53% (p=0.041 n=6)
SerializeFromPdata/STEF/serialize-4                  136.2m ±  1%   137.8m ±  2%        ~ (p=0.065 n=6)
SerializeFromPdata/STEFU/serialize-4                 34.65m ±  1%   35.10m ±  1%   +1.32% (p=0.002 n=6)
DeserializeToPdata/STEF/deserialize-4                45.40m ±  1%   46.30m ±  1%   +1.97% (p=0.009 n=6)
DeserializeToPdata/STEFU/deserialize-4               62.32m ±  1%   63.76m ±  2%   +2.31% (p=0.002 n=6)
STEFReaderRead-4                                     2.586m ±  1%   2.479m ±  2%   -4.12% (p=0.002 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4        3.295 ± 24%    3.433 ± 21%        ~ (p=0.589 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4     77.30m ± 10%   82.00m ± 15%        ~ (p=0.132 n=6)
ReadSTEF-4                                           2.640m ±  2%   2.448m ±  3%   -7.30% (p=0.002 n=6)
ReadSTEFZ-4                                          3.394m ±  1%   3.129m ±  0%   -7.82% (p=0.002 n=6)
ReadSTEFZWriteSTEF-4                                 8.557m ±  1%   7.395m ±  0%  -13.58% (p=0.002 n=6)
geomean                                              21.01m         20.68m         -1.60%

                                                 │ bench-main.txt │            bench-new.txt             │
                                                 │   sec/point    │   sec/point    vs base               │
SerializeNative/STEF/serialize-4                     117.8n ±  3%    113.5n ±  4%   -3.57% (p=0.045 n=6)
SerializeNative/STEFU/serialize-4                    514.3n ±  7%    525.1n ±  2%        ~ (p=0.104 n=6)
DeserializeNative/STEF/deser-4                       37.49n ±  0%    36.09n ±  4%   -3.72% (p=0.017 n=6)
DeserializeNative/STEFU/deser-4                      107.1n ±  0%    107.6n ±  1%   +0.47% (p=0.048 n=6)
SerializeFromPdata/STEF/serialize-4                  2.037µ ±  1%    2.061µ ±  2%   +1.18% (p=0.045 n=6)
SerializeFromPdata/STEFU/serialize-4                 518.2n ±  1%    525.0n ±  1%   +1.32% (p=0.002 n=6)
DeserializeToPdata/STEF/deserialize-4                679.2n ±  1%    692.5n ±  1%   +1.97% (p=0.006 n=6)
DeserializeToPdata/STEFU/deserialize-4               932.2n ±  1%    953.8n ±  2%   +2.31% (p=0.002 n=6)
STEFReaderRead-4                                     38.67n ±  1%    37.08n ±  2%   -4.12% (p=0.002 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4       4.188µ ± 24%    4.363µ ± 21%        ~ (p=0.513 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4     98.26n ± 10%   104.20n ± 15%        ~ (p=0.121 n=6)
ReadSTEF-4                                           39.52n ±  2%    36.63n ±  3%   -7.30% (p=0.002 n=6)
ReadSTEFZ-4                                          50.80n ±  1%    46.83n ±  0%   -7.81% (p=0.002 n=6)
ReadSTEFZWriteSTEF-4                                 128.1n ±  2%    110.7n ±  0%  -13.58% (p=0.002 n=6)
geomean                                              221.0n          217.5n         -1.61%

                                                 │ bench-main.txt │            bench-new.txt             │
                                                 │      B/op      │     B/op      vs base                │
SerializeNative/STEF/serialize-4                     3.341Mi ± 0%   3.341Mi ± 0%       ~ (p=0.818 n=6)
SerializeNative/STEFU/serialize-4                    7.530Mi ± 0%   7.530Mi ± 0%       ~ (p=0.511 n=6)
DeserializeNative/STEF/deser-4                       934.4Ki ± 0%   934.4Ki ± 0%       ~ (p=1.000 n=6) ¹
DeserializeNative/STEFU/deser-4                      1.471Mi ± 0%   1.471Mi ± 0%       ~ (p=1.000 n=6)
SerializeFromPdata/STEF/serialize-4                  74.82Mi ± 0%   74.82Mi ± 0%       ~ (p=0.242 n=6)
SerializeFromPdata/STEFU/serialize-4                 7.530Mi ± 0%   7.530Mi ± 0%       ~ (p=0.784 n=6)
DeserializeToPdata/STEF/deserialize-4                31.97Mi ± 0%   31.97Mi ± 0%       ~ (p=0.597 n=6)
DeserializeToPdata/STEFU/deserialize-4               38.64Mi ± 0%   38.64Mi ± 0%  +0.00% (p=0.002 n=6)
STEFReaderRead-4                                     936.2Ki ± 0%   936.2Ki ± 0%       ~ (p=1.000 n=6)
STEFSerializeMultipart/astronomy-otelmetrics-4       3.362Gi ± 0%   3.362Gi ± 0%       ~ (p=0.937 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4     20.59Mi ± 0%   20.59Mi ± 0%       ~ (p=1.000 n=6)
ReadSTEF-4                                           936.2Ki ± 0%   936.2Ki ± 0%       ~ (p=0.219 n=6)
ReadSTEFZ-4                                          10.27Mi ± 0%   10.27Mi ± 0%  +0.00% (p=0.002 n=6)
ReadSTEFZWriteSTEF-4                                 13.43Mi ± 0%   13.43Mi ± 0%       ~ (p=0.680 n=6)
geomean                                              10.48Mi        10.48Mi       +0.00%
¹ all samples are equal

                                                 │ bench-main.txt │            bench-new.txt            │
                                                 │   allocs/op    │  allocs/op   vs base                │
SerializeNative/STEF/serialize-4                      2.651k ± 0%   2.651k ± 0%       ~ (p=0.727 n=6)
SerializeNative/STEFU/serialize-4                      885.0 ± 0%    885.0 ± 0%       ~ (p=1.000 n=6)
DeserializeNative/STEF/deser-4                         465.0 ± 0%    465.0 ± 0%       ~ (p=1.000 n=6) ¹
DeserializeNative/STEFU/deser-4                        469.0 ± 0%    469.0 ± 0%       ~ (p=1.000 n=6) ¹
SerializeFromPdata/STEF/serialize-4                   134.7k ± 0%   134.7k ± 0%       ~ (p=0.303 n=6)
SerializeFromPdata/STEFU/serialize-4                   886.0 ± 0%    886.0 ± 0%       ~ (p=1.000 n=6) ¹
DeserializeToPdata/STEF/deserialize-4                 756.2k ± 0%   756.2k ± 0%       ~ (p=1.000 n=6)
DeserializeToPdata/STEFU/deserialize-4                944.9k ± 0%   944.9k ± 0%       ~ (p=1.000 n=6) ¹
STEFReaderRead-4                                       465.0 ± 0%    465.0 ± 0%       ~ (p=1.000 n=6) ¹
STEFSerializeMultipart/astronomy-otelmetrics-4        13.15M ± 0%   13.15M ± 0%       ~ (p=0.216 n=6)
STEFDeserializeMultipart/astronomy-otelmetrics-4      2.295k ± 0%   2.295k ± 0%       ~ (p=1.000 n=6)
ReadSTEF-4                                             466.0 ± 0%    466.0 ± 0%       ~ (p=1.000 n=6) ¹
ReadSTEFZ-4                                            504.0 ± 0%    503.5 ± 0%       ~ (p=0.182 n=6)
ReadSTEFZWriteSTEF-4                                  1.234k ± 0%   1.234k ± 0%       ~ (p=0.455 n=6)
geomean                                               6.361k        6.360k       -0.01%
¹ all samples are equal
Benchmark result 
benchstat bench-new.txt
goos: linux
goarch: amd64
pkg: github.com/splunk/stef/benchmarks
cpu: AMD EPYC 7763 64-Core Processor                
                                                 │ bench-new.txt │
                                                 │    sec/op     │
SerializeNative/STEF/serialize-4                    7.595m ±  4%
SerializeNative/STEFU/serialize-4                   35.10m ±  1%
DeserializeNative/STEF/deser-4                      2.413m ±  4%
DeserializeNative/STEFU/deser-4                     7.196m ±  1%
SerializeFromPdata/STEF/serialize-4                 137.8m ±  2%
SerializeFromPdata/STEFU/serialize-4                35.10m ±  1%
DeserializeToPdata/STEF/deserialize-4               46.30m ±  1%
DeserializeToPdata/STEFU/deserialize-4              63.76m ±  2%
STEFReaderRead-4                                    2.479m ±  2%
STEFSerializeMultipart/astronomy-otelmetrics-4       3.433 ± 21%
STEFDeserializeMultipart/astronomy-otelmetrics-4    82.00m ± 15%
ReadSTEF-4                                          2.448m ±  3%
ReadSTEFZ-4                                         3.129m ±  0%
ReadSTEFZWriteSTEF-4                                7.395m ±  0%
geomean                                             20.68m

                                                 │ bench-new.txt │
                                                 │   sec/point   │
SerializeNative/STEF/serialize-4                    113.5n ±  4%
SerializeNative/STEFU/serialize-4                   525.1n ±  2%
DeserializeNative/STEF/deser-4                      36.09n ±  4%
DeserializeNative/STEFU/deser-4                     107.6n ±  1%
SerializeFromPdata/STEF/serialize-4                 2.061µ ±  2%
SerializeFromPdata/STEFU/serialize-4                525.0n ±  1%
DeserializeToPdata/STEF/deserialize-4               692.5n ±  1%
DeserializeToPdata/STEFU/deserialize-4              953.8n ±  2%
STEFReaderRead-4                                    37.08n ±  2%
STEFSerializeMultipart/astronomy-otelmetrics-4      4.363µ ± 21%
STEFDeserializeMultipart/astronomy-otelmetrics-4    104.2n ± 15%
ReadSTEF-4                                          36.63n ±  3%
ReadSTEFZ-4                                         46.83n ±  0%
ReadSTEFZWriteSTEF-4                                110.7n ±  0%
geomean                                             217.5n

                                                 │ bench-new.txt │
                                                 │     B/op      │
SerializeNative/STEF/serialize-4                    3.341Mi ± 0%
SerializeNative/STEFU/serialize-4                   7.530Mi ± 0%
DeserializeNative/STEF/deser-4                      934.4Ki ± 0%
DeserializeNative/STEFU/deser-4                     1.471Mi ± 0%
SerializeFromPdata/STEF/serialize-4                 74.82Mi ± 0%
SerializeFromPdata/STEFU/serialize-4                7.530Mi ± 0%
DeserializeToPdata/STEF/deserialize-4               31.97Mi ± 0%
DeserializeToPdata/STEFU/deserialize-4              38.64Mi ± 0%
STEFReaderRead-4                                    936.2Ki ± 0%
STEFSerializeMultipart/astronomy-otelmetrics-4      3.362Gi ± 0%
STEFDeserializeMultipart/astronomy-otelmetrics-4    20.59Mi ± 0%
ReadSTEF-4                                          936.2Ki ± 0%
ReadSTEFZ-4                                         10.27Mi ± 0%
ReadSTEFZWriteSTEF-4                                13.43Mi ± 0%
geomean                                             10.48Mi

                                                 │ bench-new.txt │
                                                 │   allocs/op   │
SerializeNative/STEF/serialize-4                     2.651k ± 0%
SerializeNative/STEFU/serialize-4                     885.0 ± 0%
DeserializeNative/STEF/deser-4                        465.0 ± 0%
DeserializeNative/STEFU/deser-4                       469.0 ± 0%
SerializeFromPdata/STEF/serialize-4                  134.7k ± 0%
SerializeFromPdata/STEFU/serialize-4                  886.0 ± 0%
DeserializeToPdata/STEF/deserialize-4                756.2k ± 0%
DeserializeToPdata/STEFU/deserialize-4               944.9k ± 0%
STEFReaderRead-4                                      465.0 ± 0%
STEFSerializeMultipart/astronomy-otelmetrics-4       13.15M ± 0%
STEFDeserializeMultipart/astronomy-otelmetrics-4     2.295k ± 0%
ReadSTEF-4                                            466.0 ± 0%
ReadSTEFZ-4                                           503.5 ± 0%
ReadSTEFZWriteSTEF-4                                 1.234k ± 0%
geomean                                              6.360k

@tigrannajaryan
Add some decoding size limits
c1096ad 
- Set limit on column sizes
- Add varheader size limits

Without limits we were potentially trying to do huge allocations. Fuzz tests caught these.
@tigrannajaryan tigrannajaryan force-pushed the tigran/fix-bugs-fuzfound branch from 6196f52 to c1096ad Compare December 19, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhisheksplunk abhisheksplunk Awaiting requested review from abhisheksplunk

@maheshkanote maheshkanote Awaiting requested review from maheshkanote

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tigrannajaryan