Rollback insignia fix #7196
Merged
Rollback insignia fix #7196
+169
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BMagnu
added
the
regression
This was referenced Jan 22, 2026
wookieejedi
approved these changes
Jan 22, 2026
Member
wookieejedi
left a comment
wookieejedi
left a comment
There was a problem hiding this comment.
Revision matches look good, thanks for taking the time to work on these tedious clang appeasements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls back the insignia fix bit of #6849.
Apparently, two or so FSPort retail models had broken POFs that caused problems with the fix, so roll back the insignias to being incorrectly lit and faded for now, until someone has time to work around the broken models.
To fix the insignia bugs properly, one needs to revert this revert again, but make sure to analyze the insignia geometry in modelread.cpp, splitting non-adjacent faces so that multiple insignias in a single slot are correctly split into multiple insignia instances.