Fix documentation on docs.rs #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the `doc_auto_cfg` feature, but that's been renamed to just `doc_cfg`.
Member
Author
|
Another option would be to just remove the use of a nightly feature here, the only thing it affects is |
MarijnS95
reviewed
Dec 14, 2025
| @@ -1,5 +1,7 @@ | |||
| # Unreleased | |||
|
|
|||
| - Fix documentation building on `docs.rs`. | |||
Member
There was a problem hiding this comment.
Not a user-facing change, probably not useful to have in the changelog - maybe just yank 0.4.7 given the nature of the .8 followup?
Member
Author
There was a problem hiding this comment.
Well, softbuffer v0.4.7 isn't broken for anything but docs.rs, so in that sense yanking it is also wrong.
Idk., I'm also fine with yanking it and rewriting the changelog (but then I'd kinda want the changelog to say why it was yanked).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the
doc_auto_cfgfeature, but that's been renamed to justdoc_cfg.This causes the documentation to fail building on docs.rs, see the build logs.
I'll submit a new release after this.