Skip to content

Skip tidy target-specific check for run-make-cargo too #150237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Dec 22, 2025
Merged

Skip tidy target-specific check for run-make-cargo too #150237

bors merged 1 commit into from
Dec 22, 2025
+6 −2

Conversation

@jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Dec 22, 2025

I forgot to change this when implementing the run-make fission.

Noticed in #149624 (comment).

@jieyouxu
tidy: skip target-specific check for run-make-cargo too
5fc0030 
I forgot to change this when implementing the run-make fission.
@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 22, 2025

r? @Zalathar

rustbot has assigned @Zalathar.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zalathar
Copy link
Member

Zalathar commented Dec 22, 2025

Looks good.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 22, 2025

📌 Commit 5fc0030 has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2025
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 22, 2025
Merged
bors added a commit that referenced this pull request Dec 22, 2025
@bors
Auto merge of #150240 - JonathanBrouwer:rollup-anx8c35, r=JonathanBro…
e951f47 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #149840 (Update comment for `STAGE0_MISSING_TARGETS`)
 - #150109 (crash test readme: point to rustc-dev-guide)
 - #150204 (Port `#[cfi_encoding]` to attribute parser)
 - #150237 (Skip tidy target-specific check for `run-make-cargo` too)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fdc84e8 into rust-lang:main Dec 22, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Dec 22, 2025
@rust-timer
Unrolled build for #150237
9ed9194 
Rollup merge of #150237 - jieyouxu:tidy-run-make-cargo, r=Zalathar

Skip tidy target-specific check for `run-make-cargo` too

I forgot to change this when implementing the run-make fission.

Noticed in #149624 (comment).
@rustbot rustbot added this to the 1.94.0 milestone Dec 22, 2025
@jieyouxu jieyouxu deleted the tidy-run-make-cargo branch December 22, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Zalathar Zalathar

Labels

A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jieyouxu @rustbot @Zalathar @bors