Port #[cfi_encoding] to attribute parser
#150204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
requested changes
Dec 20, 2025
compiler/rustc_sanitizers/src/cfi/typeid/itanium_cxx_abi/encode.rs
Outdated
Show resolved
Hide resolved
| impl<S: Stage> SingleAttributeParser<S> for CfiEncodingParser { | ||
| const PATH: &[Symbol] = &[sym::cfi_encoding]; | ||
| const ALLOWED_TARGETS: AllowedTargets = | ||
| AllowedTargets::AllowListWarnRest(&[Allow(Target::Fn), Allow(Target::Struct)]); |
Contributor
There was a problem hiding this comment.
I don't think it makes sense to apply this attribute to a function.
I think it does make sense on Struct,ExternTy, Enum and Union.
This is what I got from quickly trying to read https://rcvalle.com/docs/rust-cfi-design-doc.pdf
@rcvalle Could you verify the list of attribute targets that #[cfi_encoding] is sensible on?
Contributor
Author
There was a problem hiding this comment.
updated to be Struct, ForeignTy, Enum and Union
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Bryntet
force-pushed
the
parse_cfi_encoding
branch
from
57419ef to
c5db47b
Compare
Signed-off-by: Edvin Bryntesson <epost@edvinbryntesson.se>
Bryntet
force-pushed
the
parse_cfi_encoding
branch
from
c5db47b to
73dbdfb
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Bryntet
force-pushed
the
parse_cfi_encoding
branch
from
73dbdfb to
d719a49
Compare
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 22, 2025
…uwer Rollup of 4 pull requests Successful merges: - #149840 (Update comment for `STAGE0_MISSING_TARGETS`) - #150109 (crash test readme: point to rustc-dev-guide) - #150204 (Port `#[cfi_encoding]` to attribute parser) - #150237 (Skip tidy target-specific check for `run-make-cargo` too) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 22, 2025
Rollup merge of #150204 - Bryntet:parse_cfi_encoding, r=JonathanBrouwer Port `#[cfi_encoding]` to attribute parser The error message is kind of saying the same thing twice, would like input on which .expect function I should use instead to not have it be double, otherwise this passes all tests locally where this attribute is used r? `@JonathanBrouwer`
Contributor
|
Minor perf regression in #150240 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message is kind of saying the same thing twice, would like input on which .expect function I should use instead to not have it be double, otherwise this passes all tests locally where this attribute is used
r? @JonathanBrouwer