Rollup of 3 pull requests #150089

JonathanBrouwer · 2025-12-17T11:49:22Z

Successful merges:

Implement va_arg for Hexagon targets #150008 (Implement va_arg for Hexagon targets)
Avoid unhelpful suggestion when crate name is invalid #150044 (Avoid unhelpful suggestion when crate name is invalid)
Port #[rustc_never_returns_null_ptr] to attribute parser #150086 (Port #[rustc_never_returns_null_ptr] to attribute parser)

r? @ghost
@rustbot modify labels: rollup

Implements proper variadic argument handling for hexagon-unknown-linux-musl targets using a 3-pointer VaList structure compatible with LLVM's HexagonBuiltinVaList implementation. * Handles register save area vs overflow area transition * Provides proper 4-byte and 8-byte alignment for arguments * Only activates for hexagon+musl targets via Arch::Hexagon & Env::Musl

Pointing out they can set the crate's name is non-actionable: their problem is they found out how and set it incorrectly. Remove extraneous information that can only confuse the matter.

…rtdev Implement va_arg for Hexagon targets Implements proper variadic argument handling for hexagon-unknown-linux-musl targets using a 3-pointer VaList structure compatible with LLVM's HexagonBuiltinVaList implementation. * Handles register save area vs overflow area transition * Provides proper 4-byte and 8-byte alignment for arguments * Only activates for hexagon+musl targets via Arch::Hexagon & Env::Musl

…relevant-rename, r=jieyouxu Avoid unhelpful suggestion when crate name is invalid Pointing out they can set the crate's name is non-actionable: their problem is they found out how and set it incorrectly. Remove extraneous information that can only confuse the matter.

…inter, r=JonathanBrouwer Port `#[rustc_never_returns_null_ptr]` to attribute parser Ports `#[rustc_never_returns_null_ptr]` to be parsed using the attribute parser r? `@JonathanBrouwer`

JonathanBrouwer · 2025-12-17T11:52:18Z

@bors r+ rollup=never p=5

bors · 2025-12-17T11:52:22Z

📌 Commit 84d441f has been approved by JonathanBrouwer

It is now in the queue for this repository.

bors · 2025-12-17T13:55:40Z

⌛ Testing commit 84d441f with merge 68f11a1...

bors · 2025-12-17T17:13:01Z

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 68f11a1 to main...

rust-timer · 2025-12-17T17:13:56Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#150008	Implement va_arg for Hexagon targets	`f8c1a47c59827d953a70ea3c3bbd535621cf536c` (link)
#150044	Avoid unhelpful suggestion when crate name is invalid	`fa5729cac9e20df5067dee3068f6a8dac814794f` (link)
#150086	Port `#[rustc_never_returns_null_ptr]` to attribute parser	`d3c7f80e60f23900a2b9457f3b01c810a159e844` (link)

previous master: f2c70877a7

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-12-17T17:16:09Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f2c7087 (parent) -> 68f11a1 (this PR)

Test differences

Show 13 test diffs

Stage 2

[run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)

Additionally, 12 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: x86_64-gnu-nopt

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 68f11a11b666b36137374b6e54fc0d013a3b26cf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 9387.0s -> 7744.3s (-17.5%)
x86_64-gnu-gcc: 4094.3s -> 3424.9s (-16.3%)
x86_64-rust-for-linux: 3733.9s -> 3135.8s (-16.0%)
pr-check-2: 3069.3s -> 2637.2s (-14.1%)
x86_64-gnu-llvm-21-2: 5247.4s -> 5985.6s (+14.1%)
i686-gnu-1: 7509.2s -> 8531.1s (+13.6%)
dist-powerpc64le-linux-musl: 5749.6s -> 5037.9s (-12.4%)
x86_64-gnu-nopt: 9912.4s -> 8722.5s (-12.0%)
dist-x86_64-apple: 7429.7s -> 8291.9s (+11.6%)
i686-gnu-2: 5294.2s -> 5902.3s (+11.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-12-17T17:55:14Z

Finished benchmarking commit (68f11a1): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.2%, 1.1%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.7%, secondary 1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.4%, 2.9%]	2
Regressions ❌ (secondary)	1.6%	[0.7%, 2.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[2.4%, 2.9%]	2

Cycles

Results (primary 2.7%, secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.2%, 3.2%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.7%, -2.1%]	2
All ❌✅ (primary)	2.7%	[2.2%, 3.2%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 483.372s -> 483.218s (-0.03%)
Artifact size: 390.57 MiB -> 390.58 MiB (0.00%)

JonathanBrouwer · 2025-12-17T18:02:18Z

@rust-timer build d3c7f80

rust-timer · 2025-12-17T18:03:44Z

Finished benchmarking commit (d3c7f80): comparison URL.

Overall result: no relevant changes - BENCHMARK(S) FAILED

❗ ❗ ❗ ❗ ❗
Warning ⚠️: The following benchmark(s) failed to build:

Job failure

❗ ❗ ❗ ❗ ❗

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: missing data

JonathanBrouwer · 2025-12-17T18:23:15Z

@rust-timer build d3c7f80

JonathanBrouwer · 2025-12-17T19:16:51Z

@rust-timer build d3c7f80

JonathanBrouwer · 2025-12-17T19:33:11Z

@rust-timer ping

rust-timer · 2025-12-17T19:33:14Z

Command cannot be empty

JonathanBrouwer · 2025-12-17T19:33:26Z

@rust-timer build d3c7f80

JonathanBrouwer · 2025-12-17T20:00:52Z

Ok one more try
@rust-timer build d3c7f80

Kobzol · 2025-12-17T20:27:15Z

You have to ask nicely!

Please:

@rust-timer build d3c7f80

rust-timer · 2025-12-17T21:26:44Z

Finished benchmarking commit (d3c7f80): comparison URL.

Overall result: no relevant changes - no action needed

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.0%, secondary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.0%	[2.3%, 3.7%]	2
Regressions ❌ (secondary)	1.8%	[1.7%, 2.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	[-0.8%, -0.8%]	1
All ❌✅ (primary)	3.0%	[2.3%, 3.7%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 483.372s -> 482.536s (-0.17%)
Artifact size: 390.57 MiB -> 390.56 MiB (-0.00%)

JonathanBrouwer · 2025-12-17T21:31:36Z

I don't see the other 2 PRs affecting perf, and the perf graphs of the affected benchmarks do look kinda noisy, so I'm calling this noise then

Kobzol · 2025-12-17T22:30:45Z

Yeah, it's fine. It wasn't even marked as a regression previously.

androm3da and others added 8 commits December 14, 2025 19:54

fixup! Implement va_arg for Hexagon Linux musl targets

d8a0f80

fixup! Implement va_arg for Hexagon Linux musl targets

4ff4b25

Avoid unhelpful suggestion when crate name is invalid

25cc98f

Pointing out they can set the crate's name is non-actionable: their problem is they found out how and set it incorrectly. Remove extraneous information that can only confuse the matter.

Port #[rustc_never_returns_null_ptr] to attribute parser

5692064

Rollup merge of rust-lang#150086 - Bryntet:parse_never_return_null_po…

84d441f

…inter, r=JonathanBrouwer Port `#[rustc_never_returns_null_ptr]` to attribute parser Ports `#[rustc_never_returns_null_ptr]` to be parsed using the attribute parser r? `@JonathanBrouwer`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 17, 2025

bors merged commit 68f11a1 into rust-lang:main Dec 17, 2025
12 checks passed

rustbot added this to the 1.94.0 milestone Dec 17, 2025

This comment has been minimized.

Sign in to view

bors mentioned this pull request Dec 17, 2025

c_variadic: provide our own va_arg implementation for more targets #150094

Open

This comment has been minimized.

Sign in to view

Uh oh!

Rollup of 3 pull requests #150089

Rollup of 3 pull requests #150089

Conversation

JonathanBrouwer commented Dec 17, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Dec 17, 2025

Uh oh!

bors commented Dec 17, 2025

Uh oh!

bors commented Dec 17, 2025

Uh oh!

bors commented Dec 17, 2025

Uh oh!

Uh oh!

rust-timer commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Test differences

Stage 2

Job duration changes

Uh oh!

rust-timer commented Dec 17, 2025

Overall result: ❌ regressions - no action needed

Uh oh!

JonathanBrouwer commented Dec 17, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Dec 17, 2025

Overall result: no relevant changes - BENCHMARK(S) FAILED

Uh oh!

JonathanBrouwer commented Dec 17, 2025

Uh oh!

JonathanBrouwer commented Dec 17, 2025

Uh oh!

JonathanBrouwer commented Dec 17, 2025

Uh oh!

rust-timer commented Dec 17, 2025

Uh oh!

JonathanBrouwer commented Dec 17, 2025

Uh oh!

JonathanBrouwer commented Dec 17, 2025

Uh oh!

Kobzol commented Dec 17, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Dec 17, 2025

Overall result: no relevant changes - no action needed

Uh oh!

JonathanBrouwer commented Dec 17, 2025

Uh oh!

Kobzol commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

JonathanBrouwer commented Dec 17, 2025 •

edited by rustbot

Loading