Skip to content

Conversation

@Fabian-Gruenbichler
Copy link
Contributor

@Fabian-Gruenbichler Fabian-Gruenbichler commented Dec 16, 2025

like Illumos and AIX, Hurd was missed when originally introducing locking gates per target OS. building rustc on Hurd was broken as a result since 1.91.

like Illumos (rust-lang#148322) and aix (rust-lang#148619), Hurd was missed when originally
introducing locking gates per target OS in rust-lang#132977. building rustc on Hurd was
broken as a result since 1.91.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 16, 2025
@Fabian-Gruenbichler
Copy link
Contributor Author

(marked as draft for now because my test build of 1.91.1 with this backported is still running, and I want to ensure it works as expected end-to-end before it gets merged!)

@workingjubilee
Copy link
Member

Thanks for the fix. This obviously seems fine if it fixes the issue, which you will know better, so, r=me after you verify.

r? @workingjubilee
@bors delegate+

@bors
Copy link
Collaborator

bors commented Dec 16, 2025

✌️ @Fabian-Gruenbichler, you can now approve this pull request!

If @workingjubilee told you to "r=me" after making some further change, please make that change, then do @bors r=@workingjubilee

@Fabian-Gruenbichler Fabian-Gruenbichler marked this pull request as ready for review December 17, 2025 12:52
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@Fabian-Gruenbichler
Copy link
Contributor Author

bors r=@workingjubilee

@Fabian-Gruenbichler
Copy link
Contributor Author

can confirm that building 1.91.1 with a backport of this and --bypass-bootstrap-lock works, and a rebuild using that 1.91.1 build without --bypass-bootstrap-lock works as well, so I would consider this ready for reviewing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants