Use slug in wishlist url

app/controllers/amazon_search_controller.rb

@@ -21,7 +21,7 @@ def amazon_client
     end
 
     def set_wishlist
-      @wishlist = Wishlist.find(params[:wishlist_id])
+      @wishlist = Wishlist.find_by_slug(params[:wishlist_id])
     end
 
     def pundit_user

app/controllers/wishlist_items_controller.rb

@@ -7,7 +7,7 @@ def index
   end
 
   def create
-    wishlist = Wishlist.find(params[:wishlist_id])
+    wishlist = Wishlist.find_by_slug(params[:wishlist_id])
     authorize wishlist.wishlist_items.build
 
     @wishlist_item = wishlist.wishlist_items.create!(wishlist_item_create_params)

app/controllers/wishlists_controller.rb

@@ -3,7 +3,7 @@ class WishlistsController < ApplicationController
 
   def show
     skip_authorization
-    @wishlist = Wishlist.includes(wishlist_items: :item).find(params[:id])
+    @wishlist = Wishlist.includes(wishlist_items: :item).find_by_slug(params[:id])
     @site_managers = @wishlist.users
     @wishlist_items = @wishlist.wishlist_items.priority_order
   end
@@ -50,7 +50,7 @@ def destroy
   private
     # Use callbacks to share common setup or constraints between actions.
     def set_wishlist
-      @wishlist = Wishlist.find(params[:id])
+      @wishlist = Wishlist.find_by_slug(params[:id])
     end
 
     # Never trust parameters from the scary internet, only allow the white list through.

app/models/wishlist.rb

@@ -17,4 +17,17 @@ class Wishlist < ApplicationRecord
 
   validates :name, presence: true,
                    uniqueness: true
+
+  def to_param
+    slug
+  end
+
+  before_save :create_slug
+  before_update :create_slug
+
+  private
+
+  def create_slug
+    self.slug = name.parameterize
+  end
 end

db/migrate/20171023124712_add_column_slug_to_wishlists.rb

@@ -0,0 +1,6 @@
+class AddColumnSlugToWishlists < ActiveRecord::Migration[5.1]
+  def change
+    add_column :wishlists, :slug, :string
+    add_index :wishlists, :slug, unique: true
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20170908012526) do
+ActiveRecord::Schema.define(version: 20171023124712) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -76,6 +76,8 @@
     t.text "name"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
+    t.string "slug"
+    t.index ["slug"], name: "index_wishlists_on_slug", unique: true
   end
 
   add_foreign_key "pledges", "users"

spec/features/managing_items_and_wishlists_spec.rb

@@ -104,12 +104,11 @@
 
     scenario "I can update an existing wishlist" do
       click_link "DC General"
-      dc_general_path = current_path
       click_link "Edit Wishlist"
       fill_in("wishlist_name", with: "VA General")
       click_button "Update Wishlist"
 
-      expect(current_path).to eq dc_general_path
+      expect(current_path).to eq wishlist_path('va-general')
       expect(page).to have_text "Wishlist was successfully updated."
       expect(page).to have_text "VA General"
     end

spec/routing/wishlists_routing_spec.rb

@@ -30,6 +30,5 @@
     it "routes to #destroy" do
       expect(:delete => "/wishlists/1").to route_to("wishlists#destroy", :id => "1")
     end
-
   end
 end