Feature/battery state broadcaster #2086
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
…et_dependencies Replace ament_target_dependencies with target_link_libraries
Don't make a temporary copy of semantic component
Recent commit in realtime_tools [1] causes the following compilation
failure:
battery_state_broadcaster/src/BatteryStateBroadcaster.cpp:28:24:
error: ‘sensor_msgs::msg::BatteryState_<std::allocator<void> >
realtime_tools::RealtimePublisher<sensor_msgs::msg::BatteryState_<std::allocator<void>
> >::msg_’ is private within this context
This commit fixes that.
[1]: ros-controls/realtime_tools@9e26e41
Fix compile error with latest realtime_tools
christophfroehlich
added
backport-jazzy
6 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2086 +/- ##
==========================================
- Coverage 84.79% 84.44% -0.35%
==========================================
Files 151 153 +2
Lines 14605 14665 +60
Branches 1266 1269 +3
==========================================
Hits 12384 12384
- Misses 1763 1823 +60
Partials 458 458
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves https://github.com/ipa320/ros_battery_monitoring/tree/main/battery_state_broadcaster to our repository.
For discsussion about this, see #1888