-
Notifications
You must be signed in to change notification settings - Fork 436
Integrate tricycle_controller into steering_controller_library #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1695 +/- ##
==========================================
- Coverage 85.69% 85.67% -0.03%
==========================================
Files 123 123
Lines 11896 11928 +32
Branches 1015 1015
==========================================
+ Hits 10194 10219 +25
- Misses 1379 1387 +8
+ Partials 323 322 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
|
Hi @christophfroehlich , I noticed that Issue #2042 (updating odometry for tricycle) is currently blocked pending the completion of this integration. I am very interested in picking up this architectural migration, especially after my recent deep dive into the steering_controllers_library (fixing the open-loop timeout behavior). Would you be open to me taking over this PR? :) I can:
Please let me know if I should work off a fork of this branch or start fresh! |
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
Closes #850